sertain / sertain-legacy

:robot: Write more for your robot with less
https://sertain.github.io/javadocs
MIT License
9 stars 3 forks source link

Pathfinder timesteps are off #48

Closed andrewda closed 6 years ago

andrewda commented 6 years ago

This definitely accounts for some of the weird things we've been seeing, specifically Pathfinder not adhering to our max velocties.

https://github.com/sertain/sertain/blob/e8e1db36c077bee8ecf34dba3617175a9b41451e/core/src/main/kotlin/org/sertain/util/Pathfinder.kt#L41

I think someone might very well have been high while writing that line 😜. The comment is right but the value is wrong. Should be 0.02 = 20 millis.

andrewda commented 6 years ago

Let's not change this until after Houston.

andrewda commented 6 years ago

Using 0.02s, our PowerUp code MAX_VELOCITY should be 1.5 m/s, much more reasonable than 0.6 m/s which we were constantly going faster than. Not quite sure how acceleration will scale, but I think it should come out to something like 0.25 m/s.

SUPERCILEX commented 6 years ago

@andrewda 🤦‍♂️ Damn, well I guess that means I should lessen up my daily tequila shots. 😆

andrewda commented 6 years ago

Imma fix this one, will need some basic re-tuning before Girl's Gen.