search

sertansenturk / tomato

Turkish-Ottoman Makam (M)usic Analysis TOolbox
GNU Affero General Public License v3.0
34 stars 6 forks source link

setup script doesn't work when installing package via pip #89

Open alastair opened 5 years ago

alastair commented 5 years ago

For dunya, we install the source package of tomato into our own pypi mirror and install it with pip. We seem to be running into some issues with the custom install class (related to #22?). Specifically:

sertansenturk commented 5 years ago

Hi Alastair,

It's nice to hear from you! I would love to help. However, I will be on vacation for the next three weeks from tomorrow, so I will not have time to make the changes by myself until the end of June.

I know it is a long time to wait, so I would be very happy to grant you (if you don't have it already), Miguel and/or anyone else access to make the appropriate fixes. Would it be OK?

Looking forward to hearing from you! Sertan

P.S: In addition to fixing the installation, we could dockerize tomato when I return...

On Wed, May 29, 2019 at 11:53 AM Alastair Porter notifications@github.com wrote:

For dunya, we install the source package of tomato into our own pypi mirror and install it with pip. We seem to be running into some issues with the custom install class (related to #22 https://github.com/sertansenturk/tomato/issues/22?). Specifically:

  • installing dependencies as a subprocess means that pip can't automatically manage them. This means that if I specify exact versions of packages in my requirements file, tomato install will overwrite them. This could be fixed by putting the dependencies in install_requires
  • tomato installs jupyter as a dependency. This isn't strictly needed as a dependency to run the algorithms in the package. I would prefer that this wasn't installed when installing only the package,
  • pip runs setup.py bdist_wheel and then installs the wheel instead of calling setup.py install, which means that the custom install class isn't used, and packages aren't downloaded. Perhaps this could be fixed by overriding a different install stage so that binaries are downloaded during the build stage?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/sertansenturk/tomato/issues/89?email_source=notifications&email_token=ABCURYOZP3P4WCUYXVZUIM3PXZOA7A5CNFSM4HQLQU4KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GWOOCXA, or mute the thread https://github.com/notifications/unsubscribe-auth/ABCURYJ7QUNZCN23XKLZYE3PXZOA7ANCNFSM4HQLQU4A .

alastair commented 5 years ago

We're happy to make the changes ourselves, if you make me an admin on the project then I'll work with Miguel to make the changes.

sertansenturk commented 5 years ago

Ok I've added you to the collaborators, which should give you push access (supposedly Miguel already has that enabled).

I think it should suffice for your to have access, bit please let me know if you need something extra)...

sertansenturk commented 4 years ago

Hi @alastair,

Had some time to play with the code over Christmas holidays. I think the current dev branch has this problem fixed.

If you can confirm, I can close this issue.