To band return str - Githubissues

sertit / eoreader

Remote-sensing opensource python library reading optical and SAR sensors, loading and stacking bands, clouds, DEM and spectral indices in a sensor-agnostic way.

https://eoreader.readthedocs.io/en/latest/

Apache License 2.0

271 stars 22 forks source link

To band return str #139

Closed jsetty closed 2 months ago

jsetty commented 2 months ago

Please review the guidelines for contributing to this repository.

[ ] Check the commit's or even all commits' message styles matches our requested structure.
[ ] Check your code additions will fail neither code linting checks nor unit test.

Could not check any of the boxes above as there is no commit message style in the guidelines and no test suite.

Issue #138

Thank you!

remi-braun commented 2 months ago

Hi ! Thanks to this proposal 😄

I'd prefer to change the output type only if a keyword is added (i.e. as_list defaulting to True) This behaviour should be also replicated to the to_str function, to keep it symmetric.

remi-braun commented 2 months ago

Thanks! Could you now add a line in CHANGES.md with a small text and a reference to this PR ? (see other lines to get inspiration) Don't hesitate to cite yourself 😉

jsetty commented 2 months ago

Suggested changes made and added the changes to CHANGES.md. Sorry for the mess!

remi-braun commented 2 months ago

Nice! Can I merge?

jsetty commented 2 months ago

Yes, please :)