sertit / eoreader

Remote-sensing opensource python library reading optical and SAR sensors, loading and stacking bands, clouds, DEM and spectral indices in a sensor-agnostic way.
https://eoreader.readthedocs.io/en/latest/
Apache License 2.0
271 stars 22 forks source link

ENH: Rationalize get_band_path functions #31

Open remi-braun opened 2 years ago

remi-braun commented 2 years ago

It could be great to rationalize all the functions that gravite around get_band_path, and see which one needs to be public or private. The actual issue is that this function orthorectifies, reprojects in UTM or geocodes the arrays under the hood, which can be time consuming and not desired.

So it could be better to disambiguate these function names:

Other sensor specific function that may need to be grouped or generalized:

Other functions managing paths but which don't pose any problem:

If no clearer way of managing this is found, at least an update in the documentation is needed.

remi-braun commented 2 years ago

Manage raw band files in a better way, for example using a regex and factorizing the code.

remi-braun commented 2 years ago

get_raw_band_paths becomes public and is generalized to all products.

remi-braun commented 2 years ago

get_raw_band_paths becomes public and is generalized to all products.

This must be documented (i.e. in VHR/SAR notebooks)

remi-braun commented 1 year ago

💡 It would also be nice to be able to retrieve all the band paths (spectral bands, but also DEM, clouds and spectral indices) with get_band_paths ➡️ One big question though for get_band_paths alignement: should it compute the paths asked (copied on non-ortho bands) 🔗 From https://github.com/sertit/eoreader/issues/80