Update Base62.java - Githubissues

guilhermeblanco commented 5 years ago

Properly fixed the actual estimated length when converting between bases
Pad with 0-bytes based on estimated final encoded length, not on original message length

guilhermeblanco commented 5 years ago

Hm... I think I made a mistake. Give me some time to inspect the length calculation, this part seems inaccurate. The other part for left-padding zero is correct though. =)

seruco commented 5 years ago

Hi Guilherme,

Thanks for the input! 😃 (And sorry for the late comment, I was busy during the last couple of weeks.)

The estimated output length was only meant to initialise the ByteArrayOutputStream with a sensible capacity. I'm not sure if padding with zeroes to the estimatedOutputLength is correct. What are your thoughts on this?

Also: out is reversed before being returned, so it essentially is already left-padded.

This implementation is kept very close to https://github.com/tuupola/base62, since I've used Mika's approach to Base 62 encoding as a reference. So far it produces the same outputs as the PHP library and I'd rather not change anything that isn't broken.

seruco / base62

Update Base62.java #1