serundeputy / get_pos

Get Drupal translation files.
1 stars 0 forks source link

Some languages are missing #1

Closed olafgrabienski closed 7 years ago

olafgrabienski commented 7 years ago

The tool downloads most but not all .po files which are available on https://localize.drupal.org/download. Seems that Drupal's iso.inc and Backdrop's standard.inc are not up to date.

Using the master (Drupal) branch, two languages are missing:

Using the Backdrop branch, eight languages are missing:

olafgrabienski commented 7 years ago

Possible solution:

We could file issues against Backdrop and Drupal core to update the .inc files. (The language list in Backdrop is however much shorter than the list in Drupal. Don't know for what reason.)

Or workaround:

serundeputy commented 7 years ago

We should be able to add the languages to the array that is built in get_pos.php without modifying or breaking Backdrop or Drupal core.

Can you file an issue in backdrop/backdrop-issues with regards to the missing languages in core/includes/standard.inc and if that is received well, i.e. ping @quicksketch on the issue, we can file one against Drupal as well.

olafgrabienski commented 7 years ago

Yes, will do it!

olafgrabienski commented 7 years ago

Issue done: https://github.com/backdrop/backdrop-issues/issues/2610

serundeputy commented 7 years ago

@olafgrabienski I've added the missing languages to an array:

// There are some languages misssing from iso.inc
// @see https://github.com/serundeputy/get_pos/issues/1
$missing = array(
  'tvy' => array(0 => 'Tuvan'),
  'prs' => array(0 => 'Afghanistan Persian'),
);

we'll see what happens with the upstream issue https://github.com/backdrop/backdrop-issues/issues/2610

thanks, ~Geoff

olafgrabienski commented 7 years ago

@serundeputy Thanks for adding the missing languages. I tested the script and missed Tuvan. The reason is a typo in my issue description, sorry for that! I wrote tvy but it has to be tyv.

serundeputy commented 7 years ago

fixed! thanks!