Question content type needs fields to record votes.

serundeputy / qa_forum

Question and answer forum with voting, follow/subscribe to issues, and user dashboard.

Other

0 stars 1 forks source link

Question content type needs fields to record votes. #3

Open serundeputy opened 7 years ago

serundeputy commented 7 years ago

Add fields to question content type in qa_forum.install:

up_votes (total of up_votes)
down_votes (total of down_votes)
score (sum of up_votes + down_votes)

These should be hidden fields.

serundeputy commented 7 years ago

I'm not sure if we need the fields on the question content type. Right now score is being calculated on the fly.

We'll see if this becomes too expensive of a calculation and if storing it on the content type would result in faster page loads?

If so how to ensure that the fields on the question content type are in sync with the qaf_events table?

jenlampton commented 7 years ago

Why a custom solution and not use votingapi? With an existing solution it would be easy to add votes to comments as well as nodes, and there are any number of existing vote-collection widgets already available.

serundeputy commented 7 years ago

No really good reason. I just didn't want to inherit any cruft and solve a problem in as streamlined, backdrop native, way as possible.

That doesn't mean votingapi is bad, and may be a better solution here, but I'd like to have specific reasons to port it be they speed or more functionality, or both.

jenlampton commented 7 years ago

I just didn't want to inherit any cruft

I hear that, but ...

but I'd like to have specific reasons to port it

not reinventing the wheel
choosing a proven solution
benefit people moving from Drupal -> Backdrop who already use voting API
probably less work to port than to write from scratch

serundeputy commented 7 years ago

Those are good reasons :)

but i've already written the functionality is now just a matter of data storage for performance (which is more performant the flattened table or storing it on the node? that requires testing).

I also would like if qa_forum is self contained solution for users that want stackoverflow type thing and depend on as little contrib as possible. I've been on the userland end of just install this module and this module, and this module needs this lib and this module ... which sometimes just results in frustration especially for beginners.

jenlampton commented 7 years ago

is now just a matter of data storage for performance

problems likely already solved with existing solutions... ;)

I've been on the userland end of just install this module and this module, and this module needs this lib and this module...

I hear that!!! Just keep in mind that the more features you add, the fewer adopters you'll find you have, as each feature is likely to turn someone away. Don't do too much! :) Keep an eye out for easy places where you can say "if you also want X feature use Y module".