serut / meteor-coverage

Server and client coverage for Meteor
MIT License
54 stars 14 forks source link

Switching from the deprecated istanbul-api to istanbuljs #53

Closed SimonSimCity closed 6 years ago

SimonSimCity commented 7 years ago

Are there plans switching from istanbul-api to istanbuljs?

This might also be related to https://github.com/istanbuljs/nyc/issues/648, since the possibility to run meteor using nyc directly would (in my eyes) deprecate this repository in itself 😉

serut commented 7 years ago

No you cannot run nyc on top of meteor because meteor only runs the compilation on its thread. Then, it creates another thread with your app... nyc is not designed to handle such process fork.
My lib runs istanbul-api on runtime, which looks like the only way to collect coverage...! To sum up :

I do not plan to update meteor-coverage as I am not working on meteor app right now, but if you want to try, your PR would be welcome !

hexsprite commented 7 years ago

I got nyc working with Meteor just fine, but it requires to invoke Meteor without the bootstrap script.

Details here:

https://forums.meteor.com/t/using-istanbul-nyc-for-code-coverage-in-meteor/38258