serut / meteor-coverage

Server and client coverage for Meteor
MIT License
54 stars 14 forks source link

Update legacy-coverage for Meteor 3 #91

Closed StorytellerCZ closed 1 month ago

StorytellerCZ commented 2 months ago

A quick attempt to upgrade legacy-coverage for Meteor 3. Haven't tested, but I think this is a good start.

serut commented 2 months ago

Hello ! Thanks for your MR. Did you test it ? I'm not working on Meteor right now so I cannot test it...

alisnic commented 1 month ago

this will not be enough unfortunately, as the code uses Assets.getText, which is now async. See https://github.com/meteor/meteor/pull/13155/files.

Will try to find a workaround

Update: this will need to make configuration initialization async

Update 2: everything runs, but coverage is Unknown 0/0%

jankapunkt commented 1 month ago

Note: I merged this into an own branch migration/3.0 to continue to work on this as it's easier to work on a branch of this PR than to fiddle between fork and upstream.