search

servalproject / serval-dna

The Serval Project's core daemon that implements Distributed Numbering Architecture (DNA), MDP, VoMP, Rhizome, MeshMS, etc.
http://servalproject.org
Other
170 stars 81 forks source link

Serval Version is build the wrong way #100

Closed adur1990 closed 7 years ago

adur1990 commented 8 years ago

The version of serval is determined by parsing the git rev-list --abbrev-commit --max-count=1 HEAD output. But if you build Serval not from the serval-dna folder but a different one, this either results in UNKNOWN-VERSION or a commit id of another repository.

I found this issue, when i was compiling serval to openWRT, since i run make from the openWRT folder and not from the serval-dna folder.

lakeman commented 8 years ago

So we should provide --git-dir=<path> and / or --work-tree=<path>? (patches welcome)

quixotique commented 7 years ago

Fixed in 29a771e3152eb15ba1236d95c4ad758d51d76e41