search

servalproject / serval-dna

The Serval Project's core daemon that implements Distributed Numbering Architecture (DNA), MDP, VoMP, Rhizome, MeshMS, etc.
http://servalproject.org
Other
171 stars 80 forks source link

SID listing now exposed as /restful/meshms/identitylist.json #80

Closed TobiasWooldridge closed 10 years ago

TobiasWooldridge commented 10 years ago

This changeset introduces an identitylist method for listing Serval identities via the MeshMS REST API.

I don't test for a large number of SIDs as SID generation for tests is quite slow (if IDENTITY_COUNT=100, the tests still pass, however SSID generation is simply slow to justify doing that every time the tests are run)

lakeman commented 10 years ago

This API doesn't really have anything to do with meshms. We should probably move it to keyring_restful.c, change the URI & method names to match.

TobiasWooldridge commented 10 years ago

I've started moving identitylist to a file (temporarily named aardvark_restul while a name is determined for it)

The file I've created isn't being compiled and I'm getting this error message

LINK libserval.so
AR libmonitorclient.a
AR libserval.a
clangclang: : errorerror: : no such file or directory: 'objs_servald/aardvark_resful.o'
no such file or directory: 'objs_servald/aardvark_resful.o'
make: *** [servald] Error 1
make: *** Waiting for unfinished jobs....
make: *** [libserval.so] Error 1

How can I add aardvark_restful.c to the list of files to be compiled? Adding it to sourcefiles.mk and running 'make clean' followed by 'autoconf' or 'autoreconf -f i' has not worked

lakeman commented 10 years ago

That's generally been enough for me.

eg; https://github.com/servalproject/serval-dna/commit/9ed507f740db41a6e566c759fb66aa57b0b65efa#diff-cba8f29955f516accac7c115960fbf54

On Wed, Aug 20, 2014 at 1:33 PM, Tobias Wooldridge <notifications@github.com

wrote:

I've started moving identitylist to a file (temporarily named aardvark_restul while a name is determined for it)

The file I've created isn't being compiled and I'm getting this error message

LINK libserval.so AR libmonitorclient.a AR libserval.a clangclang: : errorerror: : no such file or directory: 'objs_servald/aardvark_resful.o' no such file or directory: 'objs_servald/aardvark_resful.o' make: * [servald] Error 1 make: * Waiting for unfinished jobs.... make: *\ [libserval.so] Error 1

How can I add aardvark_restful.c to the list of files to be compiled? Adding it to sourcefiles.mk and running 'make clean' followed by 'autoconf' or 'autoreconf -f i' has not worked

— Reply to this email directly or view it on GitHub https://github.com/servalproject/serval-dna/pull/80#issuecomment-52731702 .

TobiasWooldridge commented 10 years ago

I've updated this pull request; the code has been moved to keyring_restful.c, tests to keyringrestful and the API call to /keyring/identities.json

Thanks

lakeman commented 10 years ago

Cherry-picked as e79e74f