search

serverfireteam / panel

An easily configurable admin panel for Laravel applications.
MIT License
427 stars 144 forks source link

bug fix #396

Closed RezaAb closed 5 years ago

RezaAb commented 5 years ago

change vendor:publish tag names change MainController for calling another route with current URI

AlirezaAlgo commented 5 years ago

Hi Reza. Thanks. why you change the tag names?

RezaAb commented 5 years ago

Hi Reza. Thanks. why you change the tag names?

Hi. when the installation command wants to call vendor:publish, it publish all package with that tag name that you have in composer.json. so I renamed these tag names.

AlirezaAlgo commented 5 years ago

Hi Reza. Thanks. why you change the tag names?

Hi. when the installation command wants to call vendor:publish, it publish all package with that tag name that you have in composer.json. so I renamed these tag names.

good. and what about MainController? Is it necessary?

RezaAb commented 5 years ago

Hi Reza. Thanks. why you change the tag names?

Hi. when the installation command wants to call vendor:publish, it publish all package with that tag name that you have in composer.json. so I renamed these tag names.

good. and what about MainController? Is it necessary?

yeah. when we have a duplicate route that has different functionality, That is the preferred route.