search

serverless-benchmark / frontend

The actual website, that shows the results
34 stars 10 forks source link

Fix broken Github link #1

Closed peburrows closed 5 years ago

peburrows commented 5 years ago

Noticed this while clicking around today.

mattwelke commented 5 years ago

This affected me too. Note that you shouldn't include the protocol in links. In this case, it just needs to start with a forward slash.

peburrows commented 5 years ago

Note that you shouldn't include the protocol in links

Not sure where you’re getting this, but links should absolutely include the protocol if the site you are linking to is available via https (as is the case here).

mattwelke commented 5 years ago

@peburrows Upon looking closer at that link, I realize now it goes to a different domain. I was confusing it with a link to a page on the same domain but at the root of the domain, where you'd just use a /. That's why I was suggesting omitting the protocol since I thought it was at the same domain.

I see nothing wrong wrong with this PR and it will fix the broken link.

hvaara commented 5 years ago

Great work! @Strernd Would it be good to get this merged?

Strernd commented 5 years ago

Sorry I somehow completely missed the notifications! Great work, thanks!