search

serverless-components / express

⚡ Take existing Express.js apps and host them easily on cheap, auto-scaling, serverless infrastructure (AWS Lambda and AWS HTTP API).
https://serverless.com/components
Apache License 2.0
375 stars 34 forks source link

Add logic to load the app from a configured dist location if present. #61

Closed Cameron-C-Chapman closed 3 years ago

Cameron-C-Chapman commented 3 years ago

Resolves #60

I'm still having issues with deploying from a dist folder so I thought I'd give a fix a try. Just looking at the code it seems like this might do it.

I haven't actually got to test this with a real deployment yet. It seems like just using the integration tests is the easiest way to do that. Is there any reason I can't/shouldn't just provide some AWS credentials locally for a personal AWS account and run the integration test to give it a shot? I'm not sure the best way to setup the folder structure specific to this use case but generic to the integration tests, I'm open to opinions/thoughts there.

Cameron-C-Chapman commented 3 years ago

This ended up not being the issue. The conversation in #60 includes what was done to resolve the issue I was seeing.