serverless-dns / blocklists

An opinionated collection of blocklists for RethinkDNS.
https://rethinkdns.com/configure
Mozilla Public License 2.0
85 stars 26 forks source link

Separate out s3 upload and radix-trie generation #3

Closed ignoramous closed 3 years ago

ignoramous commented 3 years ago

Today, createTrie.js does both s3 upload and creating the compact, compressed radix-trie from the downloaded blocklists defined in blocklistConfig.json.

Split the upload part into its own file (uploadTrie.js or upload.py and rename downloadFromBlocklistConfig.py to download.py?) and creation can remain with createTrie.js as the name makes it apparent.

santhosh-ponnusamy commented 3 years ago

separation of download, build and upload has been done and tested at commit. https://github.com/serverless-dns/blocklists/commit/81210022176b2dcde613e534f3f1c746cb8c52fc https://github.com/serverless-dns/blocklists/runs/3171895827