Add support for domain manager plugin

serverless-heaven / serverless-aws-alias

Alias support for Serverless 1.x

MIT License

189 stars 68 forks source link

Add support for domain manager plugin #114

Closed aleksdikanski closed 6 years ago

aleksdikanski commented 6 years ago

Fixes #110

ColeTMNZ commented 6 years ago

I love this - I don't have time to test today, possibly tomorrow. (My stack is broken at the moment :-( )

Side question - for things like this, that essentially support plugins, is 'alias' plugin the best place? or would it be in domain manager plugin.

Pros For keeping in Alias plugin

Its technically just a CF resource - unrelated to Other plugins.

Cons for keeping in Alias plugin

More work and maintenance required in the alias plugin.

HyperBrain commented 6 years ago

@ColeTMNZ , the alias plugin should be able to work with arbitrary CF stack inputs and make them compatible with alias deployments. This is independent of any plugins used that add resources to the CF template. So it is correct to do it here, because other plugins must not have to be aware of aliases.

HyperBrain commented 6 years ago

Let me know when your fully done with your tests and everything works as expected.

aleksdikanski commented 6 years ago

I tested the changes with two projects, one at work and also using my serverless example project at https://github.com/aleksdikanski/serverless-example-project

So far I have not encountered any issues.

HyperBrain commented 6 years ago

Sounds good.

HyperBrain commented 6 years ago

Everything for 1.7.0 should be done now. I'll try to push it out at the weekend