search

serverless-heaven / serverless-aws-alias

Alias support for Serverless 1.x
MIT License
189 stars 68 forks source link

Supporting dash in alias name when creating api gateway authorizers #149

Closed ziadloo closed 5 years ago

ziadloo commented 5 years ago

Replacing the - in the alias for the API Gateway template name. Without this change, chosing an alias name with - in it while your definition has an API Gateway with authorizers in it will fail.

ziadloo commented 5 years ago

@HyperBrain I appreciate it if you could take a look at this. It's been sitting here for a month and a half. I need this published. Thanks.

aniva commented 5 years ago

Hi, thanks for approving it, when it will be published to npm?

Enase commented 5 years ago

coming soon.. today, I hope..

aniva commented 5 years ago

Thanks a lot and have a great day!

On Thu, Jun 13, 2019 at 5:46 AM Sergii Kovalev notifications@github.com wrote:

coming soon.. today, I hope..

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/serverless-heaven/serverless-aws-alias/pull/149?email_source=notifications&email_token=ACHTVNMUR5MC5T6PCSCKF23P2IJORA5CNFSM4GKALA62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXTEW3Q#issuecomment-501631854, or mute the thread https://github.com/notifications/unsubscribe-auth/ACHTVNOE7OG7KPTUAEAKYQ3P2IJORANCNFSM4GKALA6Q .