search

serverless-heaven / serverless-aws-alias

Alias support for Serverless 1.x
MIT License
189 stars 68 forks source link

Added support to have an alias subscribe to an existing SNS topic #94 #95

Closed zachboyd closed 6 years ago

zachboyd commented 6 years ago

Closes #94

This PR adds support for resources of type AWS::SNS::Subscription to be transferred to the alias stack. This resource will be present in the cloudformation template when a lambda subscribes to an existing SNS topic by ARN.

HyperBrain commented 6 years ago

Hi @zachboyd , thanks for the contribution 💯 .

I will review it as soon as possible.

zachboyd commented 6 years ago

Thanks! I just fixed the lint issues and pushed changes as well.

HyperBrain commented 6 years ago

BTW: The project contains a proper .editorconfig configuration file, so, if you use an editorconfig plugin in your editor, it will be automatically correct 😄

zachboyd commented 6 years ago

Great! I went ahead and installed the plugin for any future work I am able to contribute back.

baipi commented 6 years ago

Thanks @zachboyd, it's exactly what I was looking for and it works well! 👍

HyperBrain commented 6 years ago

Merging. Thanks @zachboyd for the implementation and @baipi for testing 💯