search

serverless-heaven / serverless-aws-alias

Alias support for Serverless 1.x
MIT License
189 stars 68 forks source link

Disable throttling #98

Open cgrimal opened 6 years ago

cgrimal commented 6 years ago

Hello,

related to #57, I am wondering if it is possible to disable entirely the throttling (for a stage or a method)?

I see the throttlingBurstLimit and throttlingRateLimit options, but no option to disable it.

Thanks, Clément

HyperBrain commented 6 years ago

Hi @cgrimal , if you do not set any of the throttling options, the limits are applied by AWS as mentioned in https://docs.aws.amazon.com/apigateway/latest/developerguide/api-gateway-request-throttling.html

cgrimal commented 6 years ago

Thanks for your swift answer @HyperBrain! So if I understand correctly, you cannot replicate the behaviour of unchecking the Enable throttling checkbox in the API Gateway console but the default behaviour is to apply the account throttling limits (10k requests per second and 5k requests in burst) so it will have the same effects. Am I correct?

HyperBrain commented 6 years ago

I think so. If you do not add the settings, it should be equal to unchecking. Please let me know if you experienced a different behavior. You should see the configuration you've set via the plugin in the stage settings in the AWS console.

If the handling is not correct (or expected) in this case, the proper handling should be added to the plugin for that.