serverless-operations / serverless-step-functions

AWS Step Functions plugin for Serverless Framework ⚡️
Other
1.03k stars 206 forks source link

loggingConfig is not converted to cloudformation #383

Open MrAtheist opened 4 years ago

MrAtheist commented 4 years ago

This is a (Bug Report)

Description

loggingConfig is not converted to cloudformation

For bug reports:

loggingConfig is not converted to cloudformation; thus the step function didnt have logging enabled

loggingConfig should be compiled as part of the cloudformation

stepFunctions:
  stateMachines:
    StateMachine:
      name: StateMachine${self:provider.stage}
      loggingConfig:
        level: ALL
        includeExecutionData: true
        destinations:
          - Fn::GetAtt: [AccessLogs, Arn]
      role:
        Fn::GetAtt: [StateMachineRole, Arn]

# i can see the `RoleArn` being converted

For feature proposals:

Similar or dependent issues:

Additional Data

theburningmonk commented 4 years ago

@MrAtheist do you have an example serverless.yml?

MrAtheist commented 4 years ago

ah yes! i must have mistakenly pressed some github shortcut and the ticket got sent out... I've updated the description.