serverless-operations / serverless-step-functions

AWS Step Functions plugin for Serverless Framework ⚡️
Other
1.02k stars 204 forks source link

EventBridge Scheduler Integration for Stepfunction #571

Closed jappurohit041 closed 9 months ago

jappurohit041 commented 1 year ago

Feature Proposal

For feature proposals: -> Ability to create AWS::Scheduler::Schedule triggers as an alternative to AWS::Event::Rule, which may be preferable if hitting account-wide limits on a number of AWS::Event::Rule triggers per bus (Lambdas are only able to be triggered from the default bus). -> Also, specify a timezone to run it on local time.

jappurohit041 commented 1 year ago

Please follow the work for the same in the following repository: https://github.com/distinction-dev/serverless-step-functions/tree/feat-schedule-eventbridge

ayhamdewan commented 1 year ago

Is there any update on adding this feature?

KillDozerX2 commented 12 months ago

We have the first version ready, but unfortunately our previous PR into main here was not merged, hence we're a bit stuck and we may have to cherry-pick. @lopburny can you guys check out this PR

danmactough commented 11 months ago

This is an essential enhancement to this plugin to maintain parity with Serverless. See https://github.com/serverless/serverless/pull/11935

@jappurohit041 @KillDozerX2 Can you make your PR to this repository so it can have a chance of getting merged and released?

KillDozerX2 commented 10 months ago

This is an essential enhancement to this plugin to maintain parity with Serverless. See serverless/serverless#11935

@jappurohit041 @KillDozerX2 Can you make your PR to this repository so it can have a chance of getting merged and released?

Yeah, getting there.

KillDozerX2 commented 10 months ago

This is an essential enhancement to this plugin to maintain parity with Serverless. See serverless/serverless#11935

@jappurohit041 @KillDozerX2 Can you make your PR to this repository so it can have a chance of getting merged and released?

Apologies for the delay, we've opened a new PR for this. #580

jappurohit041 commented 9 months ago

Hii @horike37 @lopburny,

Could we please have look at this issue, as it has been opened since very long and we have PR ready to implement this?

Thanks

horike37 commented 9 months ago

:tada: This issue has been resolved in version 3.15.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

jeffreydmohler commented 9 months ago

Hi @KillDozerX2, @jappurohit041, @horike37

It seems like there is a key piece that was missed here. There is no way to pass input into the target. There are no errors when an input is passed, but when deployed, it never gets set.

Serverless allows for this functionality with Lambdas (see here)

Cloudformation also allows for this pretty simply (see here)

I imagine this was just missed or overlooked when adding this new code (see here) because errors were added for InputPath and InputTransformer.

Can this issue be re-opened for this functionality to be added?

horike37 commented 9 months ago

:tada: This issue has been resolved in version 3.17.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: