search

serverless-operations / serverless-step-functions

AWS Step Functions plugin for Serverless Framework ⚡️
Other
1.03k stars 203 forks source link

feat: expand support for Redshift Data #576

Closed kmfukuda closed 1 year ago

kmfukuda commented 1 year ago

Expands support for Redshift Data.

It adds support for running statements on Redshift Serverless workgroups as well as using Secrets Manager secrets or IAM identities for authentication.

kmfukuda commented 1 year ago

Hi @lopburny Is there any chance that this could be included in the next release?

horike37 commented 1 year ago

@kmfukuda Thank you for this PR. Looks good to me.

Have you done actual tests for this feature? I mean like if this feature doesn't introduce any side effects to existing features, or if this keeps backward compatibility. Because I couldn't have enough time to check it right now.

If so, I will merge this PR and release it

kmfukuda commented 1 year ago

I deployed and executed some state machines for testing using the code before and after the change, and they all behaved as intended.

To be specific, I deployed and executed a state machine for each of the only actions redshift-data:ExecuteStatement and redshift-data:BatchExecuteStatement that can result in different permissions because of the change and each of parameter sets that collectively enable covering lines 251-315, and the state machines showed that the code after the change supports all the cases that the code before the change supports.

I have also confirmed that the other actions that are handled by getRedshiftDataPermissions within lines 317-320 support the newly supported cases.

horike37 commented 1 year ago

Thank you for the explanation. Perfect!

horike37 commented 1 year ago

:tada: This PR is included in version 3.16.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: