ScanAll method at FullPrimaryKey, HashPrimaryKey - Githubissues

serverless-seoul / dynamorm

AWS DynamoDB ORM in Typescript

Apache License 2.0

55 stars 4 forks source link

ScanAll method at FullPrimaryKey, HashPrimaryKey #11

Open extJo opened 4 years ago

extJo commented 4 years ago

BACKEND-STORY_ID One-sentence summary of changes

Is it a breaking change?: NO

Why did you make these changes?

When scan all records, for iteration, code is so dirty. So, i think scanAll support at ORM layer.

What's changed in these changes?

I added scanAll method to FullPrimaryKey class. I added scanAll method to HashPrimaryKey class.

What do you especially want to get reviewed?

Is parameter 'limit' of scanAll method needed?.

Is there any other comments that every teammate should know?

nope.

Submission Type

[ ] Bugfix
[x] New Feature
[ ] Refactor

All Submissions

[x] Have you added an explanation of what your changes?
[x] Have you written new tests for your changes, as applicable?
[x] Have you checked potential side effects that could make bad impacts to other services?

New Features

[x] Have you configured CI/CD properly?
[x] Have you configured optimal memory size and timeouts of Lambda Function?
[ ] Have you grant required permissions (e.g. IAM Policy, VPC Security Group)?
[ ] Have you made required resources (e.g. DynamoDB Table, RDS Cluster)?
[ ] Does it requires native addons dependency?