feat: upgrade generateYMLForNodeProject on http component

serverless / components

The Serverless Framework's new infrastructure provisioning technology — Build, compose, & deploy serverless apps in seconds...

https://www.serverless.com

Apache License 2.0

2.31k stars 182 forks source link

feat: upgrade generateYMLForNodeProject on http component #1031

Closed zongUMR closed 2 years ago

zongUMR commented 2 years ago

What has been implemented?

Closes https://app.asana.com/0/1200011502754281/1201300336822086/f

Steps to verify

npm i @serverless/components@canary -g
components init eggjs-starter(express-starter, koa-starter, nextjs-starter, nuxtjs-starter) --name example
cd example
rm serverless.yml
components deploy: CLI will automatically generate a new serverless.yml for this project via the http component and deploy successfully

zongUMR commented 2 years ago

@timqian Please correct me if I am wrong, I removed the last line throw Error in the generate function, because I think it's impossible to reach out to that error because of the previous checks, and we can finally return the egg YML in the end.