serverless / components

The Serverless Framework's new infrastructure provisioning technology — Build, compose, & deploy serverless apps in seconds...
https://www.serverless.com
Apache License 2.0
2.31k stars 181 forks source link

feature: friendly logging for devOps #995

Closed nabi-chan closed 2 years ago

nabi-chan commented 2 years ago

What has been implemented?

The Pull Request adds features related to overall support for CI/CD and devOps.

Closes #834

Steps to verify

~- [ ] Add output for serverless deploy and serverless info commands~

Todos:

nabi-chan commented 2 years ago

@ole3021 @medikoo Hello! May I ask you to review this PR?

ole3021 commented 2 years ago

@eahefnawy @medikoo could you please check this PR and follow up. this will add a new arg --ci to keep the log in ci tidy. i dont think --ci is a good name here, but the idea behind is great, which is to make the terminal logs as simple as possible (with just deploy results)

nabi-chan commented 2 years ago

Thank you for your feedback. @ole3021 I'm thinking of these names right now, so could you choose between them or put them on the thread if you have any good ideas?

nabi-chan commented 2 years ago

I thought it was mostly used when it wasn't isTTY, so I wrote it in negative form, but I guess it wasn't. 😅

ole3021 commented 2 years ago

@medikoo are we good to process this PR?

nabi-chan commented 2 years ago

@ole3021 Yes. The features scheduled for #945 would like to work with a different PR.

nabi-chan commented 2 years ago

@ole3021 Can you run Lint & Formatting workflows? I forgot run prettier at CLI.js :<

herrlegno commented 2 years ago

Will this be merged at some point? so this workaround won't be necessary?

Thank you.

nabi-chan commented 2 years ago

Will this be merged at some point? so this workaround won't be necessary?

Thank you.

Perhaps the form of PR you mentioned will be more helpful in addressing this goal! I think we need to close the issue. Thank you for pointing it out. ❤️