CLI Output doesn't reflect when components are removed

serverless / compose

Orchestrate Serverless Framework in monorepos

https://serverless.com/framework/docs/guides/compose

MIT License

111 stars 15 forks source link

CLI Output doesn't reflect when components are removed #100

Closed ROSeaboyer closed 2 years ago

ROSeaboyer commented 2 years ago

I tried removing a service with a few stacks, there were some dependencies, but I noticed that the output never reflected that the removed services were actually removed.

Latest version of serverless and @serverless/compose are installed, so it's not an outdated dependency issue.

This isn't a functionality issue, just a display issue within my terminal

pgrzesik commented 2 years ago

Hello @ROSeaboyer - thanks for reporting. Based on the information provider, I'm not entirely sure what the problem is? Could you share more details such as:

Environment in which you're running the commands
Presented output (either in text or as a screenshot)
Reproduction steps
What would be your expected vs current behavior Thanks a lot in advance 🙇

ROSeaboyer commented 2 years ago

In order:

zsh shell in MacOS Monterey which is using node v14.17.4; no version of serverless is installed globally, so this is solely a local npm install
See below; everything depends on stackA, stackD depends on stackB, and stackE depends on stackC stackA > removing > 335s stackB > removing > 541s stackC > removing > 541s stackD > removing > 638s stackE > removing > 638s stackF > removing > 638s
I deployed, saw that timings were continuing properly, and then I immediately removed the stack as this deploy was just to verify compose in my environment
I'd expect duration counting to stop once stack removal was complete, similar to how it's working for me in the deploy step

I'm just using a "serverless remove --stage ryan" for this; is there anything different I should be running?

mnapoli commented 2 years ago

Oh I think we never call this.successProgress('removed'); when one service has been removed 😄 (as opposed to what we do for deployment)

https://github.com/serverless/compose/blob/c5629709a53fe576ef0be6c43c8766e4627150b4/components/framework/serverless.js#L78-L92

pgrzesik commented 2 years ago

Thanks for the details @ROSeaboyer - I just managed to reproduce it, fix incoming soon

edit: yep @mnapoli 😓

ROSeaboyer commented 2 years ago

Thanks for the very quick turnaround! For my own curiosity, any word on how long it'll be for a release once that PR is merged in?

pgrzesik commented 2 years ago

Hey @ROSeaboyer - the v1.0.1 that includes this fix went out a few minutes ago