Closed pgrzesik closed 2 years ago
Looks good, should region
be added here as well?
or actually 🤔 maybe not, if users pass --region
they want to override the region… But I just want to make sure.
Looks good, should
region
be added here as well?or actually 🤔 maybe not, if users pass
--region
they want to override the region… But I just want to make sure.
That's a good point, I considered it and I think we shouldn't filter out but I realised there might be a slight bug when someone sets region
on component and then once again via cli flag - it will end up twice as an arg and it will fail on Framework level - I'll see if I can address it.
Update: In fact, we're disallowing the --region
flag so the problem does not exist. Should we keep it this way or allow the override via flag? Should it then override for all components? @mnapoli
There are:
--region
here (because multiple components could be on different regions)--region
hereDoes that make sense and is that possible?
Notes from internal discussion:
--region
doesn't make sense because the region is defined on each service (services can be deployed to different regions).Conclusion: no --region
flag globally nor on service commands.
What do we do if we want to deploy all the services into particular region based on the branch?
like our dev hosted on us-east-2 staging hosted on us-west-1 test hosted on ap-south-1
keeping region static on each branch serverless.yml file is not a good idea
Related to: https://github.com/serverless/compose/discussions/119