search

serverless / compose

Orchestrate Serverless Framework in monorepos
https://serverless.com/framework/docs/guides/compose
MIT License
110 stars 15 forks source link

fix: add ability to use interactive stream with deploy and remove fun… #174

Open shira-lev opened 1 year ago

shira-lev commented 1 year ago

Hello, Following the #173 issue, Here's a PR with the needed changes so that a serverless plugin requiring user input will be able to run in a serverless compose project.

The change is setting the streamStdout as true when invoking exec function in deploy and remove functions.

In addition I changed the no changes check in the deploy function since the output was changed in the serverless framework and the output is now - Change set did not include any changes to be deployed.

Thank you, Shira

ROSeaboyer commented 1 year ago

@shira-lev I'm not associated with serverless, but FYI, the "no changes" message that you're removing still pops up when someone isn't using changesets, so you'll probably need to alter it to check for either the changeset message you added or the existing message for a "no deploy" printout to be valid