Closed pgrzesik closed 2 years ago
should we flush all final states of progresses to verbose as well? Currently, we don't do that which might be confusing to users that expect full information in verbose logs cc @mnapoli
Yes 💯
Actually I think what we should do is that when the Progresses
is stopped (method stopAll
IIRC), it should refresh one last time but this time it should write to output.stderr
instead of output.interactiveStderr
. I'm talking about this line specifically:
That will cause:
This is something I wanted to address in #67 but it was even a bigger refactoring so I left it out. Feel free to tackle this!
This is something I wanted to address in https://github.com/serverless/compose/pull/67 but it was even a bigger refactoring so I left it out. Feel free to tackle this!
I'll try to tackle this as a part of this PR 👍
After looking a bit more into that - I think it would be better to move flushing all verbose logs from progressed outputs to file to a separate PR as I need to dive deeper into the current logic and better grasp how it's all working.
Non-progress error formatting (inline):![06DD4E63-F28E-44F1-859C-8BA854A34B9B](https://user-images.githubusercontent.com/17499590/162770013-bedbd8e8-d574-4581-9c17-53c334b83699.jpeg)
In-progress error formatting:![59D90247-0E32-4FD0-BB75-7EA29D9E3CB0_4_5005_c](https://user-images.githubusercontent.com/17499590/162770142-a3dd6377-5623-4c7b-be69-b2d4bb535fc3.jpeg)
Details in verbose:![D1E74C94-9D60-46D5-9B5A-1D3F7DCBF2AC_4_5005_c](https://user-images.githubusercontent.com/17499590/162770174-75087f26-f3c9-44e1-bf94-01c0df23b97d.jpeg)
I also have a more general question - should we flush all final states of progresses to verbose as well? Currently, we don't do that which might be confusing to users that expect full information in verbose logs cc @mnapoli
Closes: #53