search

serverless / compose

Orchestrate Serverless Framework in monorepos
https://serverless.com/framework/docs/guides/compose
MIT License
111 stars 15 forks source link

feat: Detect unsupported CLI options and throw #91

Closed pgrzesik closed 2 years ago

pgrzesik commented 2 years ago

Closes: #62

Example error with unsupported options - some of them are recognized as the Framework options D627A69F-E8CA-4171-B4D9-AE525652087C_4_5005_c

pgrzesik commented 2 years ago

@mnapoli - What do you think about the wording? Should we reword the Serverless Framework-specific part? If yes, do you have any suggestions?

I was thinking about maybe something like:

CLI options "--region", "--force" are Serverless Framework options that are not supported for Serverless Compose projects ...

what do you think?

pgrzesik commented 2 years ago

Just to be clear about wording @mnapoli - which one you prefer - the one suggested in the comment or the one that is currently in the code ? 😅

mnapoli commented 2 years ago

ohh these are slightly different, I misunderstood sorry.

The one in the screenshot is best I think (though both are great TBH).

pgrzesik commented 2 years ago

Thanks for clarification @mnapoli - all proposed changes have been addressed 💯