serverless / dashboard-plugin

The Serverless Framework Dashboard plugin
https://www.serverless.com/dashboard/
MIT License
49 stars 30 forks source link

Redirect loop when using `serverless login` during onboarding #439

Open camhashemi opened 4 years ago

camhashemi commented 4 years ago

I'm doing the quickstart, where the "onboarding" page asks me to run serverless login. Serverless login asks for my account, then takes me back to the same onboarding page. My terminal hangs on the prompt after serverless login.

serverless.yml ```yaml # Welcome to Serverless! # # This file is the main config file for your service. # It's very minimal at this point and uses default values. # You can always add more config options for more control. # We've included some commented out config examples here. # Just uncomment any of them to get that config option. # # For full config options, check the docs: # docs.serverless.com # # Happy Coding! org: camhashemi app: my-first-app service: serverless-quickstart # app and org for use with dashboard.serverless.com #app: your-app-name #org: your-org-name # You can pin your service to only deploy with a specific Serverless version # Check out our docs for more details # frameworkVersion: "=X.X.X" provider: name: aws runtime: java11 # you can overwrite defaults here # stage: dev # region: us-east-1 # you can add statements to the Lambda function's IAM Role here # iamRoleStatements: # - Effect: "Allow" # Action: # - "s3:ListBucket" # Resource: { "Fn::Join" : ["", ["arn:aws:s3:::", { "Ref" : "ServerlessDeploymentBucket" } ] ] } # - Effect: "Allow" # Action: # - "s3:PutObject" # Resource: # Fn::Join: # - "" # - - "arn:aws:s3:::" # - "Ref" : "ServerlessDeploymentBucket" # - "/*" # you can define service wide environment variables here # environment: # variable1: value1 # you can add packaging information here package: artifact: build/libs/hello-dev-all.jar functions: hello: handler: com.serverless.Handler # The following are a few example events you can configure # NOTE: Please make sure to change your handler code to work with those events # Check the event documentation for details # events: # - http: # path: users/create # method: get # - websocket: $connect # - s3: ${env:BUCKET} # - schedule: rate(10 minutes) # - sns: greeter-topic # - stream: arn:aws:dynamodb:region:XXXXXX:table/foo/stream/1970-01-01T00:00:00.000 # - alexaSkill: amzn1.ask.skill.xx-xx-xx-xx # - alexaSmartHome: amzn1.ask.skill.xx-xx-xx-xx # - iot: # sql: "SELECT * FROM 'some_topic'" # - cloudwatchEvent: # event: # source: # - "aws.ec2" # detail-type: # - "EC2 Instance State-change Notification" # detail: # state: # - pending # - cloudwatchLog: '/aws/lambda/hello' # - cognitoUserPool: # pool: MyUserPool # trigger: PreSignUp # - alb: # listenerArn: arn:aws:elasticloadbalancing:us-east-1:XXXXXX:listener/app/my-load-balancer/50dc6c495c0c9188/ # priority: 1 # conditions: # host: example.com # path: /hello # Define function environment variables here # environment: # variable2: value2 # you can add CloudFormation resource templates here #resources: # Resources: # NewResource: # Type: AWS::S3::Bucket # Properties: # BucketName: my-new-bucket # Outputs: # NewOutput: # Description: "Description for the output" # Value: "Some output value" ```
REPLACE WITH FULL COMMAND NAME output ``` serverless login ```

Installed version

Framework Core: 1.71.3
Plugin: 3.6.12
SDK: 2.3.1
Components: 2.30.12
medikoo commented 4 years ago

@astuyve are there any known issues with serverless login now?

astuyve commented 4 years ago

Not that I'm aware of. I'll investigate.

camhashemi commented 4 years ago

It seemed due to the interaction between the onboarding wizard and serverless login. The wizard was blocking login and the login was blocking the wizard. Once I skipped past the wizard, serverless login worked fine.

On Mon, Jun 1, 2020, 16:20 AJ Stuyvenberg notifications@github.com wrote:

Not that I'm aware of. I'll investigate.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/serverless/enterprise-plugin/issues/439#issuecomment-636888214, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACED7VR7W6YWESB42JLZV4LRUO2LDANCNFSM4NPYZ5KA .

Nastaliss commented 4 years ago

Same issue when trying to login for the first time on https://www.serverless.com/ I registered via command line and am getting redirected to the login page every time when trying to access the dashboard.

Nastaliss commented 4 years ago

I managed to go arround the loop by logging in via incognito mode, perhaps it is a cookie issue ?

medikoo commented 4 years ago

@astuyve I've also once observed such behavior, was constantly redirected to login page after being logged in.

We probably should investigate the browser logic which is responsible for redirecting back to login page (which eventually may happen after successful login)