Open vbichkovsky opened 3 years ago
@vbichkovsky Is issue also present when webpack plugin is not used?
@medikoo yes, it's present, just to lesser degree. I think it may have something to do with the size of the payload sent to the serverless dashboard back-end - it's much bigger when everything is bundled together (in case with webpack). Looks like this data is sent synchronously, hence increasing the duration of lambda.
I just ran the version deployed without using webpack, here are the stats:
I guess it can be easily overlooked in such conditions, but in case with a big webpack package (I included whole aws-sdk in my example) the payload in CloudWatch logs is huge and it takes more than 2 seconds (to prepare/log/send it?)
The payload I'm referring to looks like this in CloudWatch logs:
INFO SERVERLESS_ENTERPRISE {"c":true,"b":"H4sIAAAAAAAAA7VYC1PjOBL....
@vbichkovsky thanks for the details, we will check what could cause that, and get back to you
@vbichkovsky Data isn't actually sent to the back-end via HTTP request. The dashboard integration works by ingesting logs asynchronously from CloudWatch. So the only operation performed synchronously is preparing that payload to write to the log file.
There are a few things we can do to help troubleshoot this. First, if the payload in cloudwatch is huge - please try disabling gzip compression and posting the entire logged result.
You can do that by adding the following custom block in the serverless.yml
:
custom:
enterprise:
compressLogs: false
That should result in the full json payload being written out. Please then share it here.
I suspect that part of this issue is stackman
, a dependency used to capture stack traces from the node environment.
There you go, here are uncompressed logs for one invocation, with webpack plugin enabled. cloudwatch-logs.csv.log
Here is another one, without the webpack plugin. cloudwatch-logs.no-webpack.csv.log
Thanks @vbichkovsky! As I'm sure you've noticed; this appears to be an interesting interaction between stackman
and webpack
, where the webpack
ed version is 1000x larger than the non-webpacked version:
.
Generating an 8MB log file is likely quite time consuming (and also expensive both in terms of CloudWatch costs at $.50/GB ingested and compute time of the lambda invocation itself.)
Just to confirm - if there is no error in the invocation, is lambda duration impacted at all?
No, it's only impacted when there is an error.
I think it's stackman, indeed, as it tries to provide context about the error and assumes that runnable code conststs of multiple relatively short lines whereas with webpack (and other bundlers) there is just one huge line of code with all the modules bundled together.
Enabling Dashboard integration via setting org and app properties in serverless.yml while using webpack packaging and aws-sdk as a runtime dependency, results in significant Lambda runtime duration when an error occurs in the handler.
```yaml service: issue frameworkVersion: '2' org: your-org-here app: sls-issue plugins: - serverless-webpack provider: name: aws runtime: nodejs12.x stage: prod region: eu-west-1 memorySize: 256 timeout: 10 functions: hello: handler: index.hello events: - http: path: / method: get ```serverless.yml
I've prepared a sample project in a public repo: https://github.com/vbichkovsky/sls-issue In order to expose a problem, the app has to be deployed and an API Gateway endpoint has to be called.
Installed version