[Python Lambda SDK] Remove importlib dependency

serverless / dashboard

MIT License

26 stars 10 forks source link

[Python Lambda SDK] Remove importlib dependency #719

Closed selcukcihan closed 1 year ago

selcukcihan commented 1 year ago

Description

Related issue https://linear.app/serverless/issue/SC-593/python-sdk-big-latency-overhead#comment-ed4329da
Similar PR https://github.com/serverless/console/pull/718
Use VERSION file instead of relying on importlib_metadata to figure out the version.
Add a unit test that makes sure hard-coded value matches the project config's value.

Testing done

Unit tested

selcukcihan commented 1 year ago

@medikoo ready for review please 🙏

selcukcihan commented 1 year ago

Looks great 👍 Still, I've just realized I think we need to update the CI version change detection, is that correct?

Disabled for this commit

medikoo commented 1 year ago

@selcukcihan it appears integration tests failed after we've merged that in: https://github.com/serverless/console/actions/runs/4893984397/jobs/8737620240#step:7:22445

selcukcihan commented 1 year ago

@selcukcihan it appears integration tests failed after we've merged that in: https://github.com/serverless/console/actions/runs/4893984397/jobs/8737620240#step:7:22445

I'm taking a look at it