search

serverless / dashboard

MIT License
24 stars 10 forks source link

Fix pyproject-fmt version #810

Closed selcukcihan closed 1 year ago

selcukcihan commented 1 year ago

Description

Noticed that a recent PR was failing due to pyproject.toml file formatting, since pyproject-fmt released a version that breaks for us. This PR fixes the version to 0.10.0 which is known to be working for our files.

Testing done

Tested by running python -m pyproject_fmt --indent 4 pyproject.toml and verifying it does not suggest changes.

selcukcihan commented 1 year ago

@medikoo ready for review 🙏

selcukcihan commented 1 year ago

@selcukcihan wouldn't it be better to upgrade to latest version of fmt, and apply to its formatting?

We can do that, but it seems like they keep changing the order they expect from version to version.

selcukcihan commented 1 year ago

I've amended the PR to do that 👍