serverless / event-gateway

React to any event with serverless functions across clouds
https://www.serverless.com/event-gateway
Apache License 2.0
1.65k stars 97 forks source link

adding in proper router processing #488

Closed sebito91 closed 6 years ago

sebito91 commented 6 years ago

What did you implement:

Revert space parsing in the router package. This was not handling IP addresses when they are provided instead of a valid space name.

How did you implement it:

Revert a fix from #485

How can we verify it:

Todos:

Is this ready for review?: YES Is it a breaking change?: YES

codecov[bot] commented 6 years ago

Codecov Report

Merging #488 into master will increase coverage by 0.06%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #488      +/-   ##
==========================================
+ Coverage   70.77%   70.84%   +0.06%     
==========================================
  Files          37       37              
  Lines        2190     2195       +5     
==========================================
+ Hits         1550     1555       +5     
  Misses        576      576              
  Partials       64       64
Impacted Files Coverage Δ
router/path_hosted.go 83.33% <100%> (+11.9%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f4be89f...77c0f0c. Read the comment docs.