serverless / github-action

:zap::octocat: A Github Action for deploying with the Serverless Framework
Apache License 2.0
662 stars 173 forks source link

No support for lambda with docker images #72

Open jmrodriguez-lab opened 2 years ago

jmrodriguez-lab commented 2 years ago

Deploying lambdas using docker images instead of layers is possible with serverless as explained here. An example:

provider:
  name: aws
  runtime: python3.8
  stage: dev
  region: us-west-1
  ecr:
    images:
        python_lambda:
        path: ./
...

however, this requires docker command to be available in docker image specified in the Dockerfile, which is not installed.

Could it be added, please? :-)

ghost commented 2 years ago

I had this same issue as well but ended up not using this github-action. Try installing serverless manually and running the deploy command and that worked for me.

arshamg commented 1 year ago

Did you find any solution to this using Github Actions? I'm also considering using the CI/CD service from Serverless - any experience there?

ghost commented 1 year ago

This worked for me:

on:
  push:
    branches: [ "staging", "main" ]
jobs:     
  <job_name_here>:
    runs-on: ubuntu-latest
    env:
      SERVERLESS_ACCESS_KEY: ${{ secrets.SERVERLESS_ACCESS_KEY }}
      AWS_ACCESS_KEY_ID: ${{ secrets.AWS_KEY_ID }}
      AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_KEY }}
    steps:
    - uses: actions/checkout@v3
    - name: install-python
      uses: actions/setup-python@v4
      with:
        python-version: '3.8'
    - name: install serverless
      run: npm i -g serverless
    - name: severless deploy
      run: sls deploy --verbose --force
schammah commented 9 months ago

would love for the action to support that as well,

looks like this forks resolved it by adding the docker installation, merging the code would add this support and fix this issue - take a look here