serverless / guide

Serverless Guide - An open-source definitive guide to serverless architectures.
https://serverless.github.io/guide/
440 stars 42 forks source link

use gitbook to generate ebook in 3 formats (pdf,epub,mobi) #80

Closed warren-bank closed 6 years ago

warren-bank commented 6 years ago

Hi. This is something that I mostly whipped up for myself.. because I like keeping documentation offline, and I generally prefer PDF documents. The structure of your guide made it really easy. Hope you like :)

..a few quick comments:

rupakg commented 6 years ago

@warren-bank Thanks a lot for the PR. I love offline formats as well and glad you did it. I will review and get back to you. I appreciate it.

rupakg commented 6 years ago

@warren-bank Quick questions:

Having said that, I feel I would have the script run as part of a CI build process on PR merges, which will use your script to generate a new eBook in all the three formats and dump them into the ebook folder.

I would appreciate your feedback.

warren-bank commented 6 years ago

Hi.

rupakg commented 6 years ago

Hi @warren-bank Thanks for the detailed explanation. I want to keep the root folders clean of any ebook related files. Can you please move everything under the ebook folder - package*.json, SUMMARY.md, book.README.md, book.json, .bookignore, cover.jpg? The outputs of the ebook formats are nicely placed in the ebook folder, and the scripts etc. are under .scripts. That's all ok.

Hope that makes sense. Thx again for your work.

warren-bank commented 6 years ago

while such a clean division is not entirely possible..

I'm thinking:

Is it really worth rejiggering things.. just to relocate a few small json configuration files?

PS) reminder: SUMMARY.md and book.README.md were deleted several commits ago

warren-bank commented 6 years ago

hmm.. this is hacky, but..

this way:

warren-bank commented 6 years ago

I'll give it a quick test, and see what happens..

warren-bank commented 6 years ago

it may be hacky.. but it works perfectly :)

well.. almost:

rupakg commented 6 years ago

@warren-bank Thx for the updates. I like it. It is so clean now. As far as the CSS is concerned, there might be a config option to gitbook that solves it. But, awesome work. Very close to getting merged. Let's get the CSS resolved.

warren-bank commented 6 years ago

agreed.. I'm pretty deep in the weeds with the css issue right now.. and it's really weird; it's definitely an issue with gitbook. Once I get it figured out.. I'll probably have a PR for the gitbook repo too :-/

rupakg commented 6 years ago

@warren-bank Thx for working on the feedback I provided. I appreciate it. I will review the work and let you know.