Closed warren-bank closed 6 years ago
@warren-bank Thanks a lot for the PR. I love offline formats as well and glad you did it. I will review and get back to you. I appreciate it.
@warren-bank Quick questions:
summary.md
and book.readme.md
or did the script generate it?package*.json
files should be committed.[1] www.xxxx.com/yyyy
. This does not apply to the TOC though. Last Updated
date/time stamp on the cover or somewhere else.Having said that, I feel I would have the script run as part of a CI build process on PR merges, which will use your script to generate a new eBook in all the three formats and dump them into the ebook
folder.
I would appreciate your feedback.
Hi.
SUMMARY.md
and book.README.md
) by hand. This methodology was used by the first 2 commits.README.md
to generate 2 files (book_SUMMARY.md
and book_README.md
).
.gitignore
.. so they are not included in the git repo..bookignore
.. so they ARE included by gitbook
while it's running.README.md
\n#
)package.json
is required, because it contains necessary (dev) dependenciespackage-lock.json
is a new file that npm
generates to lock all of the dependencies to an exact version number.
npm install
will result in an identical environmentgitbook
plugin would be able to inspect per-page markdown content to identify all links
gitbook
plugin could be used to inject some additional markdown before the ebooks are generated
Hi @warren-bank Thanks for the detailed explanation. I want to keep the root folders clean of any ebook related files. Can you please move everything under the ebook
folder - package*.json
, SUMMARY.md
, book.README.md
, book.json
, .bookignore
, cover.jpg
? The outputs of the ebook formats are nicely placed in the ebook
folder, and the scripts etc. are under .scripts
. That's all ok.
Hope that makes sense. Thx again for your work.
while such a clean division is not entirely possible..
I'm thinking:
package.json
and book.json
were moved to a subdirectory
book.json
can configure the base directory.. point it back to rootcover.jpg
would still need to be in the root directoryIs it really worth rejiggering things.. just to relocate a few small json configuration files?
PS) reminder: SUMMARY.md
and book.README.md
were deleted several commits ago
hmm.. this is hacky, but..
ebook/src/*.md
[../../source/]
this way:
ebook/src
book.json
and cover.json
could also be relocatedI'll give it a quick test, and see what happens..
it may be hacky.. but it works perfectly :)
well.. almost:
gitbook
is no-longer finding its css files when generating the pdf document
src
directory (ie: ../../source/*.md
)@warren-bank Thx for the updates. I like it. It is so clean now. As far as the CSS is concerned, there might be a config option to gitbook
that solves it. But, awesome work. Very close to getting merged. Let's get the CSS resolved.
agreed.. I'm pretty deep in the weeds with the css issue right now.. and it's really weird; it's definitely an issue with gitbook. Once I get it figured out.. I'll probably have a PR for the gitbook repo too :-/
@warren-bank Thx for working on the feedback I provided. I appreciate it. I will review the work and let you know.
Hi. This is something that I mostly whipped up for myself.. because I like keeping documentation offline, and I generally prefer PDF documents. The structure of your guide made it really easy. Hope you like :)
..a few quick comments:
ebook/.scripts/install.sh
calibre
binary that's correct for the platformebook/.scripts/env.sh
ebook-convert
can be found within the installed version ofcalibre
.gitignore