search

serverless / serverless-azure-functions

Serverless Azure Functions Plugin – Add Azure Functions support to the Serverless Framework
MIT License
267 stars 162 forks source link

fix: Combine rollback log statement into one string #290

Closed tbarlow12 closed 5 years ago

tbarlow12 commented 5 years ago

Strings were being logged out of order at random for some reason. Seemed cleaner anyway to just combine them into one string and adjusted tests.

mydiemho commented 5 years ago

Strings were being logged out of order at random for some reason. Seemed cleaner anyway to just combine them into one string and adjusted tests.

we might want to dig deeper as to why log is out of order, I am seeing this in other places too (see 4th line)

Serverless: Finished uploading blob
Serverless: -> Function App not ready. Retrying...
Serverless: -> Function App not ready. Retrying...
Serverless: -> Function package uploaded successfully
Serverless: -> Function App not ready. Retrying...
tbarlow12 commented 5 years ago

Strings were being logged out of order at random for some reason. Seemed cleaner anyway to just combine them into one string and adjusted tests.

we might want to dig deeper as to why log is out of order, I am seeing this in other places too (see 4th line)

Serverless: Finished uploading blob
Serverless: -> Function App not ready. Retrying...
Serverless: -> Function App not ready. Retrying...
Serverless: -> Function package uploaded successfully
Serverless: -> Function App not ready. Retrying...

That one I can see happening since it's just on a timer. Other functions might finish before. I think in particular, there might be a Promise.all in that section which would allow the two processes to run at the same time