feat: Prompt user for confirmation to remove resource group - Githubissues

serverless / serverless-azure-functions

Serverless Azure Functions Plugin – Add Azure Functions support to the Serverless Framework

MIT License

267 stars 162 forks source link

feat: Prompt user for confirmation to remove resource group #383

Closed tbarlow12 closed 5 years ago

tbarlow12 commented 5 years ago

What did you implement:

Requires user to enter resource group name as confirmation for group removal

Closes #380

How did you implement it:

Added utility function to wait for user input
Check user input against configured resource group name
Delete if results match

How can we verify it:

Try to remove a non-deployed project
Run sls remove and then just type Enter (empty string shouldn't match), removal won't happen
Run sls remove and then type exact resource group name and removal will happen

Todos:

Note: Run npm run test:ci to run all validation checks on proposed changes

[x] Ensure there are no lint errors.
Validate via npm run lint
Note: Some reported issues can be automatically fixed by running npm run lint:fix
[x] Write tests and confirm existing functionality is not broken.
Validate via npm test
[x] Write documentation
[x] Provide verification config / commands / resources
[x] Enable "Allow edits from maintainers" for this PR
[x] Update the messages below

Is this ready for review?: YES Is it a breaking change?: NO

pjlittle commented 5 years ago

Minor comment, otherwise looks great. Thx for adding this!