WIP: Azure Function Deployment Slot

engineersamuel commented 5 years ago

What did you implement:

Closes #372

How did you implement it:

Default the slot to 'staging' in the DeploymentConfig
Append the slot name to to the function name in the ARM template
Allow the user to override the slot name --slot

How can we verify it:

Generate a new functions project and deploy, the default deploy should be staging
TBD: Now deploy to the production slot with --slot production

Todos:

Note: Run npm run test:ci to run all validation checks on proposed changes

[ ] Ensure there are no lint errors.
Validate via npm run lint
Note: Some reported issues can be automatically fixed by running npm run lint:fix
[ ] Write tests and confirm existing functionality is not broken.
Validate via npm test
[ ] Write documentation
[ ] Provide verification config / commands / resources
[ ] Enable "Allow edits from maintainers" for this PR
[ ] Update the messages below

Is this ready for review?: NO
Is it a breaking change?: NO

tbarlow12 commented 4 years ago

@engineersamuel what's the status on this? Still WIP? Were you able to deploy to a slot?

engineersamuel commented 4 years ago

@engineersamuel what's the status on this? Still WIP? Were you able to deploy to a slot?

Just pushed some of the latest work I have here. It does deploy to the given slot, however I believe this may be specific to the consumption plan. I haven't tested this on premium functions, but maybe that is out of scope for this PR? Also the Github build is failing:

src/plugins/deploy/azureDeployPlugin.ts(127,22): error TS2339: Property 'slot' does not exist on type 'AzureLoginOptions'.
src/plugins/deploy/azureDeployPlugin.ts(127,95): error TS2339: Property 'slot' does not exist on type 'AzureLoginOptions'.
src/plugins/deploy/azureDeployPlugin.ts(127,117): error TS2339: Property 'slot' does not exist on type 'AzureLoginOptions'.
src/plugins/deploy/azureDeployPlugin.ts(128,75): error TS2339: Property 'slot' does not exist on type 'AzureLoginOptions'.
src/plugins/deploy/azureDeployPlugin.ts(130,121): error TS2339: Property 'slot' does not exist on type 'AzureLoginOptions'.

However tsc and npm run test work fine locally, is there something specific to the Github build I need to do here?

zsolt-halo commented 4 years ago

Is this going to be resolved in the near future :)? (developing custom workaround if not)

tbarlow12 commented 4 years ago

@engineersamuel we will be retiring the dev branch for now, since our team is not actively working on this project and don't have time to maintain any semblance of git flow. This will allow the community to make PRs directly against master and speed up our release cycle. Thanks for your contribution! Feel free to rebase and re-open against master if you'd like

serverless / serverless-azure-functions