serverless / serverless-azure-functions

Serverless Azure Functions Plugin – Add Azure Functions support to the Serverless Framework
MIT License
266 stars 162 forks source link

CosmosDBIn binding broken #430

Closed zsolt-halo closed 4 years ago

zsolt-halo commented 4 years ago

This is a Bug Report

Description

Breaking PR: https://github.com/serverless/serverless-azure-functions/pull/399

  1. cosmosDB with direction in which should yield "$cosmosDBIn_displayName"
  2. cosmosDB with direction out which should yield "$cosmosDBOut_displayName"
  3. cosmosDBTrigger with direction in (direction is obvious here) which should yield "$cosmosDBTriggerIn_displayName"

The above mentioned PR broke the cosmosDBIn binding config by replacing it with the comsosDBTriggerIn.

IMPORTANT: Please note that the current beta version 1.0.2-19 has a feature to download the latest bindings.json from here which will result in breaking any changes we make to the current bindings.json.

Also interestingly in the referenced bindings.json the cosmosDBIn_displayName and cosmosDBOout_displayName bindings are not present at all.

Their corresponding "new names" with the same configuration options are:

However I think that bindings.json is referencing some legacy stuff.

I have only started diving into this project a few days ago so sorry if I don't understand some hidden knowledge :) please let me know if I'm wrong somewhere.

I'll do PR to fix the cosmosDBIn issue.

Additional Data

tbarlow12 commented 4 years ago

@zsolt-halo seems like this issue is resolved. Closing for now, feel free to re-open if you have other issues