serverless / serverless-azure-functions

Serverless Azure Functions Plugin – Add Azure Functions support to the Serverless Framework

MIT License

266 stars 162 forks source link

adding cosmosDBIn as an accepted trigger #431

Closed zsolt-halo closed 4 years ago

zsolt-halo commented 4 years ago

Closes #430

I think i provided appropriate info in #430 about the issue itself, and the change is self explanatory.

Is this ready for review?: YES Is it a breaking change?: NO

zsolt-halo commented 4 years ago

Linting fail due to: ##[warning]An image label with the label macos-10.13 does not exist.

codecov[bot] commented 4 years ago

Codecov Report

Merging #431 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #431   +/-   ##
=======================================
  Coverage   94.44%   94.44%           
=======================================
  Files          48       48           
  Lines        1782     1782           
  Branches      280      245   -35     
=======================================
  Hits         1683     1683           
  Misses         98       98           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9b57dac...ea0ae20. Read the comment docs.

tbarlow12 commented 4 years ago

@zsolt-halo is this issue solved by #399 ? It was incorrectly merged directly into master, but I think it might address this problem

zsolt-halo commented 4 years ago

No, if you read the issue description, all 3 binding types are required.

Let me know if something is not clear in the issue description and I will happily clarify it if I can

tbarlow12 commented 4 years ago

Hi @zsolt-halo, I merged the changes from master back into dev, so you should be able to re-target this PR at dev with no problem

zsolt-halo commented 4 years ago

Closed in favor of https://github.com/serverless/serverless-azure-functions/pull/453