serverless / serverless-azure-functions

Serverless Azure Functions Plugin – Add Azure Functions support to the Serverless Framework
MIT License
266 stars 162 forks source link

fix: Remove -v shortcut for --verbose, conflicts with --version #435

Closed tbarlow12 closed 4 years ago

tbarlow12 commented 4 years ago

What did you implement:

Currently, if you were to run sls --version or sls -v, the plugin causes it to fail because the LoggingService creates a shortcut for --verbose, which is -v. This conflicts with --version. This PR removes that shortcut and updates the documentation.

How did you implement it:

Only look for the full verbose flag within the options, set log level to info if undefined.

How can we verify it:

Run sls --version. It shouldn't fail.

Todos:

Note: Run npm run test:ci to run all validation checks on proposed changes

Is this ready for review?: YES Is it a breaking change?: NO

pjlittle commented 4 years ago

LGTM - thanks for fixing, we definitely shouldn't be stomping/failing on this.