Currently, if you were to run sls --version or sls -v, the plugin causes it to fail because the LoggingService creates a shortcut for --verbose, which is -v. This conflicts with --version. This PR removes that shortcut and updates the documentation.
How did you implement it:
Only look for the full verbose flag within the options, set log level to info if undefined.
How can we verify it:
Run sls --version. It shouldn't fail.
Todos:
Note: Run npm run test:ci to run all validation checks on proposed changes
[x] Ensure there are no lint errors. Validate via npm run lint Note: Some reported issues can be automatically fixed by running npm run lint:fix
[x] Write tests and confirm existing functionality is not broken. Validate via npm test
[x] Write documentation
[x] Provide verification config / commands / resources
[x] Enable "Allow edits from maintainers" for this PR
[x] Update the messages below
Is this ready for review?: YES
Is it a breaking change?: NO
What did you implement:
Currently, if you were to run
sls --version
orsls -v
, the plugin causes it to fail because theLoggingService
creates a shortcut for--verbose
, which is-v
. This conflicts with--version
. This PR removes that shortcut and updates the documentation.How did you implement it:
Only look for the full
verbose
flag within the options, set log level toinfo
if undefined.How can we verify it:
Run
sls --version
. It shouldn't fail.Todos:
Note: Run
npm run test:ci
to run all validation checks on proposed changesValidate via
npm run lint
Note: Some reported issues can be automatically fixed by running
npm run lint:fix
Validate via
npm test
Is this ready for review?: YES Is it a breaking change?: NO