serverless / serverless-azure-functions

Serverless Azure Functions Plugin – Add Azure Functions support to the Serverless Framework
MIT License
266 stars 162 forks source link

fix: Move reserved prop to App Service Plan #443

Closed tbarlow12 closed 4 years ago

tbarlow12 commented 4 years ago

What did you implement:

Small update to move reserved property from site resource to app service plan resource.

Closes #437

How did you implement it:

See above.

How can we verify it:

Deploy a premium node linux function app. It shouldn't fail

Todos:

Note: Run npm run test:ci to run all validation checks on proposed changes

Is this ready for review?: YES Is it a breaking change?: NO

grizzly-monkey commented 4 years ago

ETA for this merge ? Excited to see this in action.

tbarlow12 commented 4 years ago

@grizzly-monkey as soon as I can get an approval 👍 Working towards a v2 release soon

pjlittle commented 4 years ago

LGTM