feat: Allow custom app insights instrumentation key - Githubissues

serverless / serverless-azure-functions

Serverless Azure Functions Plugin – Add Azure Functions support to the Serverless Framework

MIT License

266 stars 162 forks source link

feat: Allow custom app insights instrumentation key #494

Closed tbarlow12 closed 4 years ago

tbarlow12 commented 4 years ago

What did you implement:

Enable custom app insights instrumentation key

provider:
  appInsights:
    instrumentationKey: {your_key}

How did you implement it:

If an instrumentation key is added, arm template will use that value instead of the key from the generated template

Out of scope: The default template will still create an instance of app insights - should be future PR to remove that

How can we verify it:

Deploy a function app with a custom app insights instrumentation key

Todos:

Note: Run npm run test:ci to run all validation checks on proposed changes

[x] Ensure there are no lint errors.
Validate via npm run lint
Note: Some reported issues can be automatically fixed by running npm run lint:fix
[x] Write tests and confirm existing functionality is not broken.
Validate via npm test
[x] Write documentation
[x] Provide verification config / commands / resources
[x] Enable "Allow edits from maintainers" for this PR
[x] Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO