What did you implement: add provider parameter use32BitWorkerProcess
This feature adds the use32BitWorkerProcess parameter which is utilized in the arm template to determine if you will be using a 32-bit function or a 64-bit function. No parameter previously existed to change the defaults which ultimately caused issues when implementing certain functionalities which required 64-bit functionality.
How did you implement it:
Implementation was done by modifying the serverless model to allow the configuration in the model as optional, likewise modifying the functionApp armTemplate to provide the ability to set the proper fields when pushing the template up. Unit tests have accompanied this change.
How can we verify it:
This can be verified by changing serverless.yml to:
provider:
use32BitWorkerProcess: false
Todos:
Note: Run npm run test:ci to run all validation checks on proposed changes
[x] Ensure there are no lint errors. Validate via npm run lint Note: Some reported issues can be automatically fixed by running npm run lint:fix
[x] Write tests and confirm existing functionality is not broken. Validate via npm test
[?] Write documentation, docs aren't in the repo?
[x] Provide verification config / commands / resources
[x] Enable "Allow edits from maintainers" for this PR
[x] Update the messages below
Is this ready for review?: YES Is it a breaking change?: NO
What did you implement: add provider parameter use32BitWorkerProcess
This feature adds the use32BitWorkerProcess parameter which is utilized in the arm template to determine if you will be using a 32-bit function or a 64-bit function. No parameter previously existed to change the defaults which ultimately caused issues when implementing certain functionalities which required 64-bit functionality.
How did you implement it:
Implementation was done by modifying the serverless model to allow the configuration in the model as optional, likewise modifying the functionApp armTemplate to provide the ability to set the proper fields when pushing the template up. Unit tests have accompanied this change.
How can we verify it:
This can be verified by changing
serverless.ymlto:Todos:
Note: Run
npm run test:cito run all validation checks on proposed changesValidate via
npm run lintNote: Some reported issues can be automatically fixed by running
npm run lint:fixValidate via
npm testIs this ready for review?: YES
Is it a breaking change?: NO