Open Ayzrian opened 1 year ago
Hey, @tbarlow12 I wonder if you could review my PR and merge if possible?
I have bumped into this issue on my project and would like to add support for durable bindings in your plugin.
Just spotted that need to add extra work to support orchestratorTrigger
Ok ready now.
Also should close #377
I wonder if @medikoo you could help us getting this merged?
Hey @Ayzrian - thanks a lot for the PR. I'm currently getting more familiar with the plugin and intend to dedicate some time to maintaining it in the coming weeks.
Hey, @pgrzesik thanks! So I assume that we shouldn't expect this PR to be merged in the near days, right?
In that case we will probably will use fork version util this PR is merged.
Hey @Ayzrian - definitely not, I'm still learning more about Azure serverless offerings itself as I want to be confident that the changes that I can potentially introduce won't be breaking anything. Sorry about that!
@pgrzesik no worries, take your time. Meanwhile, we decided to drop using serverless since Azure is hardly supported right now and we would prefer to use native tools.
Sure thing @Ayzrian. If you have time, could you share what are the key features that are currently missing, but it would be great if they were supported by the plugin? I'm trying to understand what would be needed to make this plugin a really great choice for building Serverless apps on Azure
@pgrzesik
Hope you can see the bug title Add support for durable function
To know about durable functions: https://learn.microsoft.com/en-us/azure/azure-functions/durable/durable-functions-overview?tabs=csharp
To know about durable function binding: https://learn.microsoft.com/en-us/azure/azure-functions/durable/durable-functions-bindings?tabs=csharp%2C2x-durable-functions
Missing triggers:
Durable function js quick start: https://learn.microsoft.com/en-us/azure/azure-functions/durable/quickstart-js-vscode
What did you implement:
Closes #553
There was no bindings definition for durable functions, so this resulted into problems in case we want to use serverless azure functions and durable functions. Added support for the bindings to generate right functions.json file.
How did you implement it:
Added definitions for possible bindings to bindings.json file.
How can we verify it:
Add durableClient input to HTTP triggered function to test it.
Todos:
Validate via
npm run lint
Note: Some reported issues can be automatically fixed by running
npm run lint:fix
Validate via
npm test
Is this ready for review?: YES
Is it a breaking change?: NO