serverless / serverless-azure-functions

Serverless Azure Functions Plugin – Add Azure Functions support to the Serverless Framework
MIT License
266 stars 159 forks source link

feat: add suport for node16 runtime #640

Closed lcsales98 closed 1 year ago

lcsales98 commented 1 year ago

What did you implement:

Closes #631

It will become available to use the nodejs16 runtime.

How did you implement it:

I'm updated the available runtimes at src/config/runtime.ts.

How can we verify it:

Can you generate an azure function with serverless-framework and deploy it with nodejs16 runtime. Ex: runtime: nodejs16

Todos:

Note: Run npm run test:ci to run all validation checks on proposed changes

Is this ready for review?: YES
Is it a breaking change?: NO

danielwaghorn commented 1 year ago

Are there any updates on being able to get this merged at all? Happy to help if required.

medikoo commented 1 year ago

Are there any updates on being able to get this merged at all? Happy to help if required.

The only problem was that author of PR didn't mark this PR as ready for re-review. Anyway it looks as good to take

medikoo commented 1 year ago

I've merged it, yet it doesn't seem to be validated in CI, and locally for me tests fails.

Before releasing it, it'll be good to fix the CI in this project (I've created an issue: https://github.com/serverless/serverless-azure-functions/issues/645) and ensure that locally all tests passes