Fix CI setup. Ensure working builds

serverless / serverless-azure-functions

Serverless Azure Functions Plugin – Add Azure Functions support to the Serverless Framework

MIT License

266 stars 159 forks source link

Fix CI setup. Ensure working builds #645

Closed medikoo closed 1 year ago

medikoo commented 1 year ago

To follow up with maintenance we need to fix CI.

Ideally, if we create a similar configuration as it's in the Serverless Framework -> https://github.com/serverless/serverless/tree/main/.github/workflows where we have three jobs:

validate - Validates PR's only, by running lint and unit tests
integrate - Which validates master by running unit and integration tests (if they exist - here I believe we can skip on that), and publishes new tag if detects changes of version in package.json
publish - Runs on version tag, publishes new version to npm

medikoo commented 1 year ago

Reopened as we still miss integrate build that publishes a new tag.

I see that there are some old integration jobs configured, but they do not seem to be triggered at all, and may no longer be valid. So we need to revisit them and put them into shape

gligorkot commented 1 year ago

@medikoo I tried fixing the integration tests, but these require an Azure subscription and I think the subscription set up within this repository might not be paid/up to date or something so they are failing. I've got something that I think might work, but I don't have a subscription to test them on.

medikoo commented 1 year ago

@gligorkot thanks for info, in light of that (as I don't have available Azure subscription which can be used for testing), can we update the integration workflow to simply run validation tests as it's done in validation job?

gligorkot commented 1 year ago

@medikoo, I have raised PR #656 to close off this job, then I suggest we deploy a version 2.2.0 so people can start using node 18 support, while next we upgrade any outdated packages and then release a version 3.0.0 - what do you think?