adding validate github action to pull requests raised to the master branch - Githubissues

serverless / serverless-azure-functions

Serverless Azure Functions Plugin – Add Azure Functions support to the Serverless Framework

MIT License

266 stars 162 forks source link

adding validate github action to pull requests raised to the master branch #646

Closed gligorkot closed 1 year ago

gligorkot commented 1 year ago

What did you implement:

Addresses a part of #645

How did you implement it:

Added a validate Github action to lint and run unit tests + report coverage

How can we verify it:

It should run on Github when a PR is raised to the master branch

Todos:

Note: Run npm run test:ci to run all validation checks on proposed changes

[x] Ensure there are no lint errors.
Validate via npm run lint
Note: Some reported issues can be automatically fixed by running npm run lint:fix
[x] Write tests and confirm existing functionality is not broken.
Validate via npm test
[x] Write documentation
[ x Provide verification config / commands / resources
[x] Enable "Allow edits from maintainers" for this PR
[x] Update the messages below

Is this ready for review?: YES Is it a breaking change?: NO

gligorkot commented 1 year ago

@medikoo this adds the validate.yml asked for in #645 - trying to get us closer to a release. Can you please have a look if this is what you expected?